Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy screening interface #1304

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

maxpkatz
Copy link
Member

All networks using this legacy approach have now been converted to use the new interface that doesn't rely on the vector of screening factors.

@maxpkatz maxpkatz marked this pull request as ready for review August 12, 2023 17:08
@zingale
Copy link
Member

zingale commented Aug 15, 2023

we should follow this up with a PR that removes the need for NETWORK_PROPERTIES and NSCREEN

@zingale zingale merged commit 255c399 into AMReX-Astro:development Aug 15, 2023
21 checks passed
@maxpkatz maxpkatz deleted the rm_old_screening_interface branch August 15, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants