Feat/#11 week7 #12
Open
Feat/#11 week7 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtaejugkim
approved these changes
Dec 19, 2024
Comment on lines
+80
to
+84
| text = when { | ||
| uiState.isLoading -> "๋ก๋ฉ ์ค..." | ||
| uiState.hobby.isNotEmpty() -> uiState.hobby | ||
| else -> "์ฐพ์ ์ ์์ต๋๋ค" | ||
| }, |
There was a problem hiding this comment.
๋ก๋ฉ์ ๋ํ ์ฒ๋ฆฌ๋ ํ์ จ๋ค์!
Comment on lines
+53
to
+60
| viewModel.sideEffect.collectLatest { sideEffect -> | ||
| when (sideEffect) { | ||
| is MyPageContract.MyPageSideEffect.ShowErrorToast -> { | ||
| Toast.makeText(context, sideEffect.message, Toast.LENGTH_SHORT).show() | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
collectLatest๋ ์ด๋ค ๋์ฅ ๋ฐฉ์์ ์ฐ์ฐ์์ธ๊ฐ์?
sayyyho
approved these changes
Dec 19, 2024
Comment on lines
+53
to
+60
| viewModel.sideEffect.collectLatest { sideEffect -> | ||
| when (sideEffect) { | ||
| is MyPageContract.MyPageSideEffect.ShowErrorToast -> { | ||
| Toast.makeText(context, sideEffect.message, Toast.LENGTH_SHORT).show() | ||
| } | ||
| } | ||
| } | ||
| } |
Comment on lines
+7
to
+27
| class SignUpContract { | ||
| data class SignUpState( | ||
| val email: String = "", | ||
| val password: String = "", | ||
| val hobby: String = "", | ||
| val isLoading: Boolean = false, | ||
| val errorMessage: String? = null | ||
| ) : UiState | ||
|
|
||
| sealed class SignUpEvent : UiEvent { | ||
| data class UpdateEmail(val email: String) : SignUpEvent() | ||
| data class UpdatePassword(val password: String) : SignUpEvent() | ||
| data class UpdateHobby(val hobby: String) : SignUpEvent() | ||
| data object SubmitSignUp : SignUpEvent() | ||
| } | ||
|
|
||
| sealed class SignUpSideEffect:UiSideEffect { | ||
| data object NavigateToLogin : SignUpSideEffect() | ||
| data class ShowSnackbar(val message: String) : SignUpSideEffect() | ||
| } | ||
| } |
Comment on lines
+62
to
+78
| LaunchedEffect(Unit) { | ||
| viewModel.sideEffect.collectLatest { sideEffect -> | ||
| when (sideEffect) { | ||
| is LoginContract.LoginSideEffect.NavigateToMyPageWithToken -> { | ||
| saveAuthToken(context, sideEffect.token) | ||
| navController.navigate("mypage") { | ||
| popUpTo("login") { inclusive = true } | ||
| } | ||
| } | ||
|
|
||
| is LoginContract.LoginSideEffect.ShowSnackbar -> { | ||
| snackbarHostState.showSnackbar(sideEffect.message) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
์ด๋ฐ์์ผ๋ก ์ฒ๋ฆฌํ ์ ์๊ฒ ๋ค์! ๋ฐฐ์๊ฐ๋๋ค!!
jihyunniiii
reviewed
Dec 24, 2024
| val loginPassword by viewModel.password.collectAsState() | ||
| var passwordVisible by remember { mutableStateOf(false) } | ||
| fun LoginScreen(navController: NavController, viewModel: LoginViewModel = hiltViewModel()) { | ||
| val uiState by viewModel.uiState.collectAsState() |
There was a problem hiding this comment.
collectAsStateWithLifecycle์ ์ฌ์ฉํ๋ฉด ์ข์ ๊ฒ ๊ฐ์ต๋๋ค ~ (์์ธ์ง๋ ์ธ๋ฏธ๋ ์๋ฃ ์ฐธ๊ณ !!)
| val loginEmail by viewModel.email.collectAsState() | ||
| val loginPassword by viewModel.password.collectAsState() | ||
| var passwordVisible by remember { mutableStateOf(false) } | ||
| fun LoginScreen(navController: NavController, viewModel: LoginViewModel = hiltViewModel()) { |
There was a problem hiding this comment.
NavController ๊ฐ์ฒด ์์ฒด๋ฅผ ๋๊ธฐ๋ ๊ฒ๋ณด๋ค ์ด๋ฅผ ์ฌ์ฉํ๋ ํจ์๋ฅผ ๋๊ฒจ์ฃผ์๋ ๊ฒ ์ข์ ๊ฒ ๊ฐ์์!
NavController ๊ฐ์ฒด ์์ฒด๋ฅผ ๋๊ธฐ๊ฒ ๋๋ฉด LoginScreen์ด ๋ค๋น๊ฒ์ด์
๊ณผ ๊ด๋ จ๋ ์ฑ
์๋ ๊ฐ์ง๊ฒ ๋์ด์ ๊ทธ ์ญํ ์ด ๋ฌด๊ฑฐ์ ์ง๋๋ค.
๋ํ, ํ
์คํธ ๋ฑ์ด ์ด๋ ต๊ฒ ๋์ด์!
Comment on lines
+128
to
+130
| text1 = stringResource(R.string.login_find_id), | ||
| text2 = stringResource(R.string.login_setting_password_again), | ||
| text3 = stringResource(R.string.sign_up), |
There was a problem hiding this comment.
์กฐ๊ธ ๋ ์ง๊ด์ ์ธ ๋ค์ด๋ฐ์ ์ฌ์ฉํด ์ฃผ์ ๋ ์ข์ ๊ฒ ๊ฐ๋ค์ !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue ๐
Work Description โ๏ธ
Screenshot ๐ธ
Uncompleted Tasks ๐
To Reviewers ๐ข
์์ง UI๋จ์ ์์ผ๋ฉด ์๋๋ ์ฝ๋๋ค์ด ์ฌ๋ฟ ๋ณด์ ๋๋ค.. ๋จธ์ฑ
ํด๋น ๋ถ๋ถ์ ์ธ์งํ๊ณ ์์ต๋๋ค. ํ๊ต ๊ณผ์ ๊ฐ ๋๋๋๋๋ก ๋ค์ ๋ถ๋ฆฌํ๊ฒ ์ต๋๋ค.
MVI๊ฐ ์ฒ์์ด๋ผ ๋ถ์กฑํ ๋ถ๋ถ์ด ๋ง์ํ ๋ฐ ๋ฐ๋ํ ์ง์ ๋ถํ๋๋ฆฌ๊ฒ ์ต๋๋ค!
ํญ์ ๊ฐ์ฌํฉ๋๋ค