Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/#9] week06 #10

Open
wants to merge 14 commits into
base: feature/#7-week04
Choose a base branch
from
Open

[Feature/#9] week06 #10

wants to merge 14 commits into from

Conversation

0se0
Copy link
Contributor

@0se0 0se0 commented Dec 6, 2024

Related issue πŸ› 

Work Description ✏️

  • ν΄λ¦°μ•„ν‚€ν…μ²˜

Screenshot πŸ“Έ

화면은 전주와 λ™μΌν•©λ‹ˆλ‹€!

Uncompleted Tasks πŸ˜…

  • μ‹œν—˜μ΄ 방금 전에 λλ‚˜μ„œ... μ‹œν—˜ λλ‚˜κ³  이전 μ΄μŠˆμ™€ ν•¨κ»˜ μ œλŒ€λ‘œ λ¦¬νŒ©ν•˜κ² μŠ΅λ‹ˆλ‹€ γ…œγ…œ

To Reviewers πŸ“’

@0se0 0se0 self-assigned this Dec 6, 2024
Copy link

@KkamSonLee KkamSonLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€! 쑰금 더 클래슀 정리가 ν•„μš”ν•΄λ³΄μ—¬μš”! 그리고 도메인과 데이터 λ ˆμ΄μ–΄λ³„ μ—­ν•  뢄리가 ν™•μ‹€ν•˜κ²Œ 되고, λ·°κΉŒμ§€ 데이터λ₯Ό 제곡 함에 μžˆμ–΄ μ–΄λ–€ νλ¦„μœΌλ‘œ κ°€λ©΄ 쒋을지 μ°Έκ³  링크 μ²¨λΆ€ν–ˆμŠ΅λ‹ˆλ‹€! λͺ¨λ“  글에 μžˆλŠ”κ²Œ 정닡은 μ•„λ‹ˆμ§€λ§Œ μ˜μ‘΄μ„± κ΄€λ¦¬λŠ” μ œλŒ€λ‘œ ν•˜λŠ”κ²Œ μ’‹μ•„μš” !! 정리 되면 λ‹€μ‹œ ν•œ 번 λ³Όκ²Œμš”!

https://velog.io/@squart300kg/%EC%95%88%EB%93%9C%EB%A1%9C%EC%9D%B4%EB%93%9C-Clean-Architecture%EB%9E%80-%EB%AC%B4%EC%97%87%EC%9D%B8%EA%B0%803

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ΅¬ν˜„μ²΄κ°€ domain 에 있고 좔상체가 data layer 에 μ‘΄μž¬ν•˜λŠ” 것 κ°™μ•„μš”! 그리고 λ·°λͺ¨λΈμ€ 좔상체λ₯Ό inject λ°›κ²Œ λ˜μ–΄ μžˆκ΅¬μš”! μ˜μ‘΄μ„± λ°©ν–₯의 μˆ˜μ •μ΄ ν•„μš” ν•  것 κ°™μŠ΅λ‹ˆλ‹€!

Copy link

@ThirFir ThirFir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€!!!!

Comment on lines +5 to +14
interface UserRepository {
suspend fun signUp(username: String, password: String, hobby: String): Result<UserEntity>
suspend fun login(username: String, password: String): Result<String>
suspend fun getHobby(token: String): Result<String>
fun saveUserInfo(userEntity: UserEntity)
fun saveUserToken(token: String)
fun getUserInfo(): Result<UserEntity>
fun getToken(): String?
fun isLoggedIn(): Boolean
fun logout()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repository의 λ©”μ„œλ“œλŠ” suspend둜 μ§€μ •λ˜κ±°λ‚˜, λ˜λŠ” Flowλ₯Ό λ°˜ν™˜κ°’μœΌλ‘œ μ§€μ •ν•˜λŠ” 것 λ‘˜ 쀑 ν•˜λ‚˜κ°€ ꢌμž₯되고 μžˆμŠ΅λ‹ˆλ‹€. sharedPreferencesλ₯Ό μ΄μš©ν•˜λ―€λ‘œ λ‹Ήμž₯은 suspend일 ν•„μš”λŠ” μ—†μ§€λ§Œ, DataStore둜 이전 될 κ°€λŠ₯성을 μ—΄μ–΄λ‘”λ‹€λ©΄ suspend둜 μ§€μ •λ˜λ©΄ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€!!

https://developer.android.com/topic/architecture/data-layer?hl=ko#expose-apis

Copy link

@chrin05 chrin05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ‹œν—˜λ³΄μ‹œλŠλΌ λ„˜ κ³ μƒλ§Žμ•˜μ–΄μš©
μ „λ°˜μ μœΌλ‘œ μ•„ν‚€ 잘 λ‚˜λˆ„μ‹ κ±° κ°™μ•„μš”!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state둜 κ΄€λ¦¬ν•˜λŠ” κ±°κΉŒμ§€ μ μš©ν•˜μ…¨κ΅°μš”! πŸ‘ 저도 λ‹€μŒκ³Όμ œ 전에 μ½”λ“œλ¦­νŒ© μ μš©ν•΄λ³΄λ„λ‘ ν•˜κ² μŠ΅λ‹ˆλ‹Ή

Comment on lines +3 to +5
import org.sopt.and.data.datasource.UserDataLocalSource
import org.sopt.and.data.datasource.UserRemoteDataSource
import org.sopt.and.data.repository.UserRepository
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainμ—μ„œλŠ” λ‹€λ₯Έ λ ˆμ΄μ–΄μ— λŒ€ν•œ μ˜μ‘΄μ„±μ΄ μ—†μ–΄μ•Όν•  κ±° κ°™μŠ΅λ‹ˆλ‹Ή!

Copy link
Member

@Roel4990 Roel4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€!

Comment on lines +45 to +52
signUpEvent = SignUpEvent.Success(userEntity.username),
isLoading = false
)
}
}.onFailure { exception ->
_signUpEvent.emit(SignUpEvent.Failure("νšŒμ›κ°€μž… 쀑 였λ₯˜ λ°œμƒ: ${exception.message}"))
_uiState.update {
it.copy(
signUpEvent = SignUpEvent.Failure(exception.message ?: "νšŒμ›κ°€μž… 쀑 였λ₯˜κ°€ λ°œμƒν–ˆμŠ΅λ‹ˆλ‹€"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ΄λ ‡κ²Œ κ΅¬ν˜„ν•˜μ‹  μ΄μœ κ°€ μžˆμ„κΉŒμš” 처음 λ³΄λŠ” 방식이라 κΆκΈˆν•©λ‹ˆλ‹€!

Copy link
Contributor

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν–ˆμ–΄μš”!

initialValue = false
).value
fun MyPageRoute(
navController: NavController,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navControllerλ₯Ό ν•˜μœ„ Composable에 인자둜 λ„˜κΈ°λŠ” 것은 ꢌμž₯λ˜λŠ” 방식이 μ•„λ‹™λ‹ˆλ‹€.
ν•˜λ‹¨ κ³΅μ‹λ¬Έμ„œ 일어보면 쒋을 것 κ°™μ•„μš”!

https://developer.android.com/develop/ui/compose/navigation?hl=ko#testing-nav-host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants