[Feat] 7주차 과제 완료 #14
Open
[Feat] 7주차 과제 완료 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyoeunjoo
approved these changes
Dec 19, 2024
Comment on lines
+38
to
+42
| fun logIn() { | ||
| setState { copy(isLoading = true) } | ||
| viewModelScope.launch { | ||
| val state = uiState.value | ||
| val result = userRepository.postUserLogin( |
There was a problem hiding this comment.
여기에 상태 업데이트와 비지니스 로직이 섞여있는 것 같아용 약간 분리해줘도 좋을 것 같은데요??
Comment on lines
+9
to
+11
| val username: String = "", | ||
| val password: String = "", | ||
| val isLoading: Boolean = false, |
sayyyho
approved these changes
Dec 19, 2024
Comment on lines
+46
to
+53
| when (effect) { | ||
| is SignUpSideEffect.ShowToast -> { | ||
| context.showToast(effect.message) | ||
| } | ||
| } | ||
|
|
||
| is RegisterState.Failure -> { | ||
| when (registerState.code) { | ||
| "00" -> context.showToast(R.string.sign_up_error) | ||
| "01" -> context.showToast(R.string.sign_up_eight) | ||
| else -> {} | ||
| is SignUpSideEffect.NavigateToLogin -> { | ||
| navController.navigate("login") { | ||
| popUpTo(0) { inclusive = true } | ||
| } |
Comment on lines
+13
to
+38
| abstract class BaseViewModel<State : UiState, SideEffect : UiSideEffect, Event : UiEvent> : | ||
| ViewModel() { | ||
|
|
||
| private val initialState: State by lazy { createInitialState() } | ||
| abstract fun createInitialState(): State | ||
|
|
||
| private val _uiState = MutableStateFlow(initialState) | ||
| val uiState: StateFlow<State> = _uiState.asStateFlow() | ||
|
|
||
| private val _sideEffect = MutableSharedFlow<SideEffect>() | ||
| val sideEffect: SharedFlow<SideEffect> = _sideEffect.asSharedFlow() | ||
|
|
||
| fun setState(reduce: State.() -> State) { | ||
| _uiState.value = _uiState.value.reduce() | ||
| } | ||
|
|
||
| fun setSideEffect(builder: () -> SideEffect) { | ||
| viewModelScope.launch { _sideEffect.emit(builder()) } | ||
| } | ||
|
|
||
| fun setEvent(event: Event) { | ||
| viewModelScope.launch { handleEvent(event) } | ||
| } | ||
|
|
||
| protected abstract suspend fun handleEvent(event: Event) | ||
| } |
jihyunniiii
reviewed
Dec 24, 2024
| import org.sopt.and.presentation.signup.components.IdHobbyTextField | ||
| import org.sopt.and.presentation.signup.components.SocialServiceLogIn | ||
| import org.sopt.and.util.showSnackBar | ||
|
|
||
| @Composable | ||
| fun LogInScreen( | ||
| navController: NavController, |
There was a problem hiding this comment.
책임 분리를 위해서 navController 자체를 인자로 받기 보다는 이를 이용한 함수를 인자로 받는 게 좋을 것 같아요!
관련한 내용이 합동 세미나 피드백에 있으니 읽어보시면 좋을 것 같습니다 ~
|
|
||
| override fun createInitialState(): LogInState = LogInState() | ||
|
|
||
| override suspend fun handleEvent(event: LogInEvent) { |
There was a problem hiding this comment.
event와 sideEffect의 차이는 뭘까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
전 주차 화면과 동일합니다!
Uncompleted Tasks 😅
To Reviewers 📢
과제 제출 기간을 잊어버렸네요... 죄송합니다...!
뷰모델과 State, SideEffect, Event를 컴포넌트화 하여 재사용하고, 행동을 정의할 수 있다는 것에 screen과 viewModel의 많은 코드 감소를 느낄 수 있었습니다! 본 과제 작동 방식이 맞는지 잘 몰라서 피드백 주시면 감사드립니다!