Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat/#12] 7주차 과제 구현 #13
base: develop
Are you sure you want to change the base?
[feat/#12] 7주차 과제 구현 #13
Changes from 4 commits
3186454
73964a1
4753dd3
7d6bff0
8c07f52
785472b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is를 붙이고 안붙이고의 차이는 뭔가요?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getMyHobby는 data class 상태(프로퍼티)를 가지며, is로 타입 검사를 통해 특정 클래스로 매칭이 필요합니다 ! onLoginButtonClick은 data object이기 때문에 상태가 없는 단일 객체로, 고유 값으로 비교가 가능합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
석준 오빠 코드리뷰 읽어보시면 좋을 듯 합니다! 이해 안 되면 저 디코로 호출하3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delay를 주는 이유가 무엇인가용??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 있고 아래도 있던데 저도 궁금합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 궁금합니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
화면 이동 되면서 스낵바가 안 떠서 delay를 줬는데 좋은 방법은 아닌 것 같아요... 다른 방법이 있을까요 ? ㅠㅠ
제가 상태관리를 잘못했나봐요...
라고 pr 글에서 말했던.... 이유입니다.......
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI단에서 이미 코루틴을 사용하는 것으로 보이는데, suspend를 지우고 viewModelScope를 넣으신 이유가 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇 그러게요.... 이부분은 제가 중복을 생각못하고 만든것 같네요 !! 수정하겠습니다 ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
위에도 있는 질문인데 is의 유무로 인해 어떤 차이가 있는 건가요!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 궁금해요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#13 (comment)
요기 달았어요!
코드 써보시면 알겠지만 is가 없다면 빨간줄이 뜹니다~
This file was deleted.