-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Vertex Reconstruction #226
Conversation
…an time selection
hi Franklin, Firstly, can i trouble you to re-introduce the Secondly and more importantly, it looks like you're leaking memory in You've also introduced a whole lot of whitespace changes in FoMCalculator so that essentially the whole file appears changed, which makes it very difficult to see what actually changed (both in reviewing PRs, but also when comparing across commits); would you be able to just apply the code changes, without changing the whitespace? Thanks |
Removed redundant GenerateFineGrid function in VtxSeedGenerator Removed experimental penalty term calculation in FoMCalculator
Hi Marcus, |
Hi Franklin, You also still have memory leaks in VtxSeedFineGrid. Finally, the new vector In fact, although it's not your code, I'd be surprised if the equivalent delete call in VtxSeedGenerator::Finalise at line 94 did not result in a double free when the ToolChain terminates. When pointers are passed to a If there's anything unclear here, please do raise it at the software meeting tomorrow. |
…r, and handling in VtxExtendedVertexFinder and MinuitOptimizer. This change is experimental, but should only trigger with appropriate config variables.
Marcus, |
Correction: now it should cause no problems. Some syntactical errors had slipped through the previous update. |
…y to vary 2D angle instead of position
…arge.root, which is the file containing pdf plot for use within new charge fitter.
hi franklin. I really have to apologise for taking so long to get this merged. There are a couple of very minor points that it would be good to make in a future PR. There are a few things declared There are some trailing cout calls that it would be good to either remove or convert to |
Added FineGrid search and mean time selection