Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning hunt #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MaximilienNaveau
Copy link

Dear all,

I noticed many warning related to shadow variable (re-declaration of variable with the same name in 1 scope).
This can really cause trouble during the run so I fixed all of them.

One more reason to do that is that on my robot these warnings are necessarily treated as errors. It's a safety measure used to prevent bugs from happening.

One detail on this PR I reverted the include name from filters (the ros package) from ".hpp" to ".h". As the headers are still maintained in the ".h" form in ROS1 noetic.
This allows me to use your code in melodic while not perturbing the usage in noetic.

@MaximilienNaveau
Copy link
Author

@mgaertneratanybotics Would you mind reviewing this PR?
I think it's gonna be very quick

@Ryanf55 Ryanf55 added the ros1 Affects ROS 1 label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros1 Affects ROS 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants