Skip to content
This repository has been archived by the owner on Sep 12, 2022. It is now read-only.

core_config_data handler for Magento 2 #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shuryoka
Copy link

@shuryoka shuryoka commented Feb 7, 2016

The database credentials are stored in "app/etc.env.php" in Magento 2. I added a new handler (Est_Handler_Magento2_CoreConfigData) and a PHP parser dependency to address that.

It might be not the best idea to have a full copy of 'Est_Handler_Magento_CoreConfigData' in the Magento 2 sphere but that could be the topic of some refactoring.

@fbrnc
Copy link
Member

fbrnc commented Feb 9, 2016

Hi @shuryoka,
thank you for this contribution. I looked at your code and have a two comments:

  • I'd like to avoid any external dependencies. Any chances you can get this done without including nikic/php-parser?
  • The file Est/Handler/Magento2/AbstractDatabase.php is formatted in a very strange way. Could you please reformat it to stick to the Magento coding guidelines

@fbrnc
Copy link
Member

fbrnc commented Feb 9, 2016

Also: I'm currently rewriting this. The new project is aoepeople/zettr. You might want to look at that.

@shuryoka
Copy link
Author

shuryoka commented Feb 9, 2016

Sure, I can do that. Would be no problem. But now that you mentioned the new and updated version at https://github.com/AOEpeople/zettr, the Magento 2 addition isn't necessary here anymore, isn't it? I would prefer the new package over this one then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants