Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: add stings-google-services dependency for APISENSE #58

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aveuiller
Copy link
Contributor

Configure integration for google places

Configure integration for google places
@@ -5,6 +5,7 @@
<string translatable="false" name="google_web_client_id" >380173086743-qasd4ru2o2jnblbugg6vkj2em6d2uih1.apps.googleusercontent.com</string>
<string translatable="false" name="facebook_app_id">1760322360873183</string>
<string translatable="false" name="fb_login_protocol_scheme">fb1760322360873183</string>
<string translatable="false" name="google_places_api_key">AIzaSyBrZsS2athB3s4LGWpQdxh7yvSYHI5R3NI</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to have the API key visible to everyone?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key is protected in use by package signature on Google side, so the risk is minimal. But I can hide it if you prefer ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey all good. 👍
It was just to be sure that no leak can appear :).

@rsommerard
Copy link
Contributor

rsommerard commented Feb 17, 2018

Should I merge it (always WIP) now or wait for the release of the sting ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants