Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "bouncing" when scrolling to input. #426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thijs-qv
Copy link

Fixes #418 (screen bouncing while focusing on of the input).

@vomchik
Copy link

vomchik commented Apr 28, 2020

@alvaromb could you review this PR?

)
}, keyboardOpeningTime)
if (this.mountedComponent) {
UIManager.measureLayout(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taichi-jp hey, why do you use this approach? I have removed setTimeout only and this works fine.
Also, with your approach, auto-scroll doesn't work when I press on a first input in the scrollview 🤷‍♂️

Copy link
Author

@thijs-qv thijs-qv Apr 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still had issues after only removing the setTimeout. Scrolling works for me on first input as well (works on my machine... 😉).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see :) hm, will try to find a reason 🕵️‍♂️

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementing the given solution works fine for me. When should we able to merge or find a solution to this issue? Thx

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When solution will be merged? Thanks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this be merged someday?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it gets merged in 2024

0,
() => {},
(x, y, width, height) => {
findNodeHandle(this._rnkasv_keyboardView), (x, y, width, height) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you use comma here?

umob-developer added a commit to umob-developer/react-native-keyboard-aware-scroll-view that referenced this pull request May 27, 2024
copied fix from APSL#426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

screen bouncing while focusing on of the input
7 participants