-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "bouncing" when scrolling to input. #426
base: master
Are you sure you want to change the base?
Conversation
@alvaromb could you review this PR? |
) | ||
}, keyboardOpeningTime) | ||
if (this.mountedComponent) { | ||
UIManager.measureLayout( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taichi-jp hey, why do you use this approach? I have removed setTimeout
only and this works fine.
Also, with your approach, auto-scroll doesn't work when I press on a first input in the scrollview 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still had issues after only removing the setTimeout. Scrolling works for me on first input as well (works on my machine... 😉).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see :) hm, will try to find a reason 🕵️♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementing the given solution works fine for me. When should we able to merge or find a solution to this issue? Thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When solution will be merged? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be merged someday?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope it gets merged in 2024
0, | ||
() => {}, | ||
(x, y, width, height) => { | ||
findNodeHandle(this._rnkasv_keyboardView), (x, y, width, height) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you use comma here?
copied fix from APSL#426
Fixes #418 (screen bouncing while focusing on of the input).