Skip to content

Commit

Permalink
fix for issue #384 in master branch
Browse files Browse the repository at this point in the history
- fix labelingMode for White Markers
- build production libs
  • Loading branch information
kalwalt committed Feb 11, 2022
1 parent 69abf00 commit 99bda00
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 0 deletions.
14 changes: 14 additions & 0 deletions aframe/build/aframe-ar.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions three.js/build/ar.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions three.js/src/threex/threex-artoolkitcontext.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,18 @@ ARjs.Context = THREEx.ArToolkitContext = function (parameters) {
// the patternRatio inside the artoolkit marker - artoolkit only
patternRatio: 0.5,

// Labeling mode for markers - ['black_region', 'white_region']
// black_region: Black bordered markers on a white background, white_region: White bordered markers on a black background
labelingMode: 'black_region',

// enable image smoothing or not for canvas copy - default to true
// https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/imageSmoothingEnabled
imageSmoothingEnabled: false,
}
// parameters sanity check
console.assert(['artoolkit'].indexOf(this.parameters.trackingBackend) !== -1, 'invalid parameter trackingBackend', this.parameters.trackingBackend)
console.assert(['color', 'color_and_matrix', 'mono', 'mono_and_matrix'].indexOf(this.parameters.detectionMode) !== -1, 'invalid parameter detectionMode', this.parameters.detectionMode)
console.assert(["black_region", "white_region"].indexOf(this.parameters.labelingMode) !== -1, "invalid parameter labelingMode", this.parameters.labelingMode);

this.arController = null;

Expand Down Expand Up @@ -247,6 +252,15 @@ ARjs.Context.prototype._initArtoolkit = function (onCompleted) {
// set the patternRatio for artoolkit
arController.setPattRatio(_this.parameters.patternRatio);

// set the labelingMode for artoolkit
var labelingModeTypes = {
"black_region": artoolkit.AR_LABELING_BLACK_REGION,
"white_region": artoolkit.AR_LABELING_WHITE_REGION
}
var labelingModeType = labelingModeTypes[_this.parameters.labelingMode];
console.assert(labelingModeType !== undefined);
arController.setLabelingMode(labelingModeType);

// set thresholding in artoolkit
// this seems to be the default
// arController.setThresholdMode(artoolkit.AR_LABELING_THRESH_MODE_MANUAL)
Expand Down

0 comments on commit 99bda00

Please sign in to comment.