Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Laravel Octane & Dependency Injection #39

Closed
wants to merge 1 commit into from
Closed

Fix for Laravel Octane & Dependency Injection #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [8.0, 8.1]
php: [8.0, 8.1, 8.2, 8.3]
dependency-version: [prefer-lowest, prefer-stable]

name: PHP ${{ matrix.php }} - ${{ matrix.dependency-version }}
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
env:
REDIS_PORT: ${{ job.services.redis.ports['6379'] }}

- name: Scrutinizer CI
run: |
composer require scrutinizer/ocular --dev
vendor/bin/ocular code-coverage:upload --format=php-clover coverage.clover
# - name: Scrutinizer CI
# run: |
# composer require scrutinizer/ocular --dev
# vendor/bin/ocular code-coverage:upload --format=php-clover coverage.clover
6 changes: 4 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
/build/
/vendor/
/.idea
/build
/vendor
.phpunit.result.cache
composer.lock
composer.phar
2 changes: 1 addition & 1 deletion src/SettingsServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public function provides(): array
*/
private function registerSettingsManager(): void
{
$this->singleton(ManagerContract::class, SettingsManager::class);
$this->bind(ManagerContract::class, SettingsManager::class);

$this->app->extend(ManagerContract::class, function (ManagerContract $manager, $app) {
foreach ($app['config']->get('settings.drivers', []) as $driver => $params) {
Expand Down
Loading