-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Adding cmweather while updating the codebase for support. #706
Conversation
zssherman
commented
Sep 7, 2023
•
edited
Loading
edited
- Closes Replace current CVD colormaps with CMWeather #705
- Documentation reflects changes
- PEP8 Standards or use of linter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there a few linting errors
@mgrover1 Yep, fixing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - nice work @zssherman
@AdamTheisen I don't think this should have any impact on systems until there is a release, then ARM systems will need to have cmweather installed, but this should be good to go for now if your cool with me merging? |
When they go to update ACT, it will have it as a new dependency which should solve the issue - the update should go hand in hand |
@mgrover1 Good point! I was thinking if they install the repo etc outside of conda-forge, but you made me realized the requirements.txt etc should handle that haha. |
Yes! This is where dependencies + versioning come in clutch. I think we can go ahead and merge? |
@mgrover1 merging! |