Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adding cmweather while updating the codebase for support. #706

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

zssherman
Copy link
Collaborator

@zssherman zssherman commented Sep 7, 2023

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there a few linting errors

@zssherman
Copy link
Collaborator Author

@mgrover1 Yep, fixing now!

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - nice work @zssherman

@zssherman
Copy link
Collaborator Author

@AdamTheisen I don't think this should have any impact on systems until there is a release, then ARM systems will need to have cmweather installed, but this should be good to go for now if your cool with me merging?

@mgrover1
Copy link
Collaborator

mgrover1 commented Sep 7, 2023

When they go to update ACT, it will have it as a new dependency which should solve the issue - the update should go hand in hand

@zssherman
Copy link
Collaborator Author

zssherman commented Sep 7, 2023

@mgrover1 Good point! I was thinking if they install the repo etc outside of conda-forge, but you made me realized the requirements.txt etc should handle that haha.

@mgrover1
Copy link
Collaborator

mgrover1 commented Sep 7, 2023

Yes! This is where dependencies + versioning come in clutch. I think we can go ahead and merge?

@zssherman zssherman merged commit 2b62427 into ARM-DOE:main Sep 7, 2023
16 checks passed
@zssherman
Copy link
Collaborator Author

@mgrover1 merging!

@zssherman zssherman deleted the cmweather branch September 7, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace current CVD colormaps with CMWeather
2 participants