Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Updates for plotting #707

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Conversation

AdamTheisen
Copy link
Collaborator

Updated skew-t plots to make it a little more robust and handle cases where data are subsetted from a 2D array.

  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

@AdamTheisen
Copy link
Collaborator Author

I'll take a look at these errors when I get some time but it probably won't be soon

@mgrover1
Copy link
Collaborator

mgrover1 commented Sep 8, 2023

I can dig into this today!

@zssherman
Copy link
Collaborator

@mgrover1 I might have a fix for this, let me check

@zssherman
Copy link
Collaborator

@mgrover1 I pushed a fix, if the changes pass, let me know if my changes look reasonable

@mgrover1
Copy link
Collaborator

mgrover1 commented Sep 8, 2023

Looks great - nice work @zssherman and @AdamTheisen !

@AdamTheisen AdamTheisen merged commit 2c1c11d into ARM-DOE:main Sep 11, 2023
16 checks passed
@AdamTheisen AdamTheisen deleted the plot_updates branch January 31, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants