Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding filename parsing for ARM filenames. #708

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Adding filename parsing for ARM filenames. #708

merged 2 commits into from
Sep 11, 2023

Conversation

kenkehoe
Copy link
Contributor

@kenkehoe kenkehoe commented Sep 8, 2023

@kenkehoe
Copy link
Contributor Author

I'm assuming this just timed out and the tests were OK. Can you rerun the testing?

@mgrover1
Copy link
Collaborator

rerunning now @kenkehoe !

mgrover1
mgrover1 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - tests pass, and the code here looks solid! Thanks for adding the tests/example here too @kenkehoe

@AdamTheisen
Copy link
Collaborator

Agreed @mgrover1 ! Thanks for getting this in @kenkehoe, very much appreciated! We can close out #700 once this is merged.

@AdamTheisen AdamTheisen merged commit b3e46d9 into ARM-DOE:main Sep 11, 2023
16 checks passed
@AdamTheisen AdamTheisen mentioned this pull request Sep 11, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamTheisen AdamTheisen AdamTheisen approved these changes

@mgrover1 mgrover1 mgrover1 approved these changes

@zssherman zssherman Awaiting requested review from zssherman zssherman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenkehoe @mgrover1 @AdamTheisen