ENH: Bug fix for geoplot example #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @AdamTheisen for the fix! |
|
Looks like the error is a syntax error |
|
It looks like one test failed so maybe this is not a permanent solution. Rerunning to see what it does. |
|
@zssherman @mgrover1 there was one last error with the geoplot test. I'm wondering if I should update the geoplot test to follow the example. Thoughts? |
|
Should we also add this fix to the tests for plot_geoplot? I know that's originally where we were having issues? |
|
@AdamTheisen Yeah I think we should, we said the same thing at the same time haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with the cartopy Stamen that is causing errors. While we sort through that, setting the stamen to terrain and the tile to 9 seems to produce consistent results.