-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Bug fix for geoplot example #722
Conversation
Thanks @AdamTheisen for the fix! |
Looks like the error is a syntax error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!!
It looks like one test failed so maybe this is not a permanent solution. Rerunning to see what it does. |
@zssherman @mgrover1 there was one last error with the geoplot test. I'm wondering if I should update the geoplot test to follow the example. Thoughts? |
Should we also add this fix to the tests for plot_geoplot? I know that's originally where we were having issues? |
@AdamTheisen Yeah I think we should, we said the same thing at the same time haha |
There's an issue with the cartopy Stamen that is causing errors. While we sort through that, setting the stamen to terrain and the tile to 9 seems to produce consistent results.