Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove verify warning, by setting verify to true. #729

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

zssherman
Copy link
Collaborator

No description provided.

@zssherman zssherman changed the title FIX: Remove verify warning, but setting verify to true. FIX: Remove verify warning, by setting verify to true. Oct 10, 2023
@AdamTheisen
Copy link
Collaborator

@zssherman let me test this out a bit. I know in the past, this caused issues with their API.

@AdamTheisen
Copy link
Collaborator

@zssherman works fine now but we might want to update the function description as we did note that we were setting that to False

Note, the requests library is indicating a bad handshake with the server so 'verify' is currently set to False which is unsecure

Wondering if we need an issue to add a citation as well... Thoughts?
USDA National Agricultural Statistics Service Cropland Data Layer. {YEAR}. Published crop-specific data layer [Online]. Available at https://nassgeodata.gmu.edu/CropScape/ (accessed {DATE}; verified {DATE}). USDA-NASS, Washington, DC.

@zssherman
Copy link
Collaborator Author

Oh yep! I missed that note, I can remove it, but agreed I think a citation would be good

@zssherman
Copy link
Collaborator Author

@AdamTheisen I updated the PR to remove the note and added the reference, let me know if it looks good!

@AdamTheisen
Copy link
Collaborator

@zssherman I think this is good to go! Thanks!

@AdamTheisen AdamTheisen merged commit cbe74cb into ARM-DOE:main Oct 12, 2023
16 checks passed
@zssherman zssherman deleted the discovery_warnings branch January 23, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants