Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Adding new example for working with ARM QC and Xarray Transforma… #734

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

AdamTheisen
Copy link
Collaborator

@AdamTheisen AdamTheisen commented Oct 13, 2023

…tions. Updating one example to follow ds convention, and fixing warn message for armfiles

  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

…tions. Updating one example to follow ds convention, and fixing warn message for armfiles
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment - otherwise, this looks great!

@AdamTheisen
Copy link
Collaborator Author

@kenkehoe just wanted to ping you on this example. Was something like this what you were thinking?

@AdamTheisen
Copy link
Collaborator Author

@mgrover1 does this look good now?

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes here!

@AdamTheisen AdamTheisen merged commit 9550ffe into ARM-DOE:main Oct 13, 2023
16 checks passed
@AdamTheisen AdamTheisen deleted the transform branch October 13, 2023 16:31
@kenkehoe
Copy link
Contributor

@AdamTheisen overall I think it looks good. I didn't actually run the code so I don't know what the plot looks like. Does the updated QC work?

@AdamTheisen
Copy link
Collaborator Author

@kenkehoe the updated qc will not work which is what I try to note in the example and why users should filter their data appropriately ahead of any transformation

@kenkehoe
Copy link
Contributor

@AdamTheisen OK sounds good. Thanks for the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants