Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery changes for V2.0.0 #737

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Discovery changes for V2.0.0 #737

merged 3 commits into from
Nov 29, 2023

Conversation

AdamTheisen
Copy link
Collaborator

@AdamTheisen AdamTheisen commented Oct 13, 2023

Major changes for this change include the renaming of all discovery functions to remove the "get" from the name and towards a consistent naming convention for the files and functions as defined in the Contributors guide.

  • Closes Standardize discovery module #688
  • Tests added
  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

@zssherman
Copy link
Collaborator

Just some PEP8 fixes, besides that, looks good to me!

@zssherman zssherman closed this Nov 29, 2023
@zssherman zssherman reopened this Nov 29, 2023
@zssherman zssherman merged commit eb45a45 into ARM-DOE:main Nov 29, 2023
32 checks passed
@AdamTheisen AdamTheisen deleted the disc_v2 branch January 31, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize discovery module
3 participants