Adding in new function

[ajsockol]

• Closes #xxxx
• Tests added
• Documentation reflects changes
• PEP8 Standards or use of linter
• Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

[zssherman]

@ajsockol Thanks for the PR! I added some review comments. Also could we add unit tests to this PR as well for the new code?

[ajsockol]

I added all the changes you mentioned except the testing. I'll add that next!

[ajsockol]

Okay, I've added the tests. Now to just figure out why the linting keeps failing

[zssherman]

@ajsockol Can you try installing pre-commit? It should help with the linting issues. I'm also trying to find out why the test_arm_qc tests are failing

[mgrover1]

@ajsockol Can you try installing pre-commit? It should help with the linting issues. I'm also trying to find out why the test_arm_qc tests are failing

It should be in your act_env development environment

within your main ACT directory you can run

pre-commit install 

Then, when you commit, it will auto-lint and fix where needed.

[zssherman]

@kenkehoe I'm still trying to familiarize with QC code of ACT, but do you possibly know why this PR might be failing the ARM QC tests?

[ajsockol]

@mgrover1 when i try to run pre-commit install . in my ACT directory (when I'm in my act_env development environment), I get this error:

[zssherman]

@ajsockol Maybe try pre-commit install from within the act directory no .
https://pre-commit.com/

[kenkehoe]

@zssherman I know why the QC test is failing. We use a production DQR to test the functionality of the ARM DQR web-service. The DQR used was reprocessed so it is now not returned in the API call. I have a fix for this in my current PR. It's a simple fix if we want to include it in this PR to allow it to pass the tests.

In act.tests.qc.test_arm_qc.py change line 15 to:

ds = add_dqr_to_qc(ds, assessment='Reprocessed,Suspect,Incorrect')

[zssherman]

@kenkehoe Ah makes sense! Thanks for the info! We could always wait to have your PR merge in and then can rerun the tests here.

[ajsockol]

Okay I got things figured out and was able to push changes through SSH. It looks like what's failing now are the arm_qc tests

[zssherman]

@ajsockol Cool, yeah looks like the linter etc are passing. Ken's PR fixes that QC issue so we can wait for that one to get approved then once its merge rerun the tests here.

[ajsockol]

Okay, I copied and pasted a fix from Ken for one of the tests that was failing, but there is still one test failing from tests/discovery/test_asos.py::test_get_region that seems to be something out of my hands. @zssherman do you know what might be going wrong there?

[zssherman]

@ajsockol It is a connection error, i'll rerun the tests which will fix it.