Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Adding jupyter hub notebook #55

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

zssherman
Copy link
Collaborator

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zssherman
Copy link
Collaborator Author

@AdamTheisen Let me know if this looks good

@AdamTheisen
Copy link
Member

@zssherman looking good! The only thing I would say is that you may want to walk them through getting into ARM's JupyterHub instance https://jupyterhub.arm.gov/, since that's where we will have them work and move the terminal test to the beginning and have them clone the ARM-Notebooks repo so they can bring up the tutorial notebooks. Does that sound reasonable?

@zssherman
Copy link
Collaborator Author

@AdamTheisen Yeah sounds good! I'll make the changes.

@zssherman
Copy link
Collaborator Author

@AdamTheisen Made the changes to include the info on ARM jupyterhub and git cloning the notebooks.

@AdamTheisen
Copy link
Member

Looks good! Thanks!

@AdamTheisen AdamTheisen merged commit b1f5473 into ARM-Development:main Jul 11, 2023
2 checks passed
@zssherman zssherman deleted the jupyterhub branch September 26, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants