Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-arm GCC targets #199

Closed
wants to merge 1 commit into from
Closed

Conversation

rsaxvc
Copy link

@rsaxvc rsaxvc commented Nov 15, 2024

Part of #32, this fixes compiling CMSIS-DSP on non-ARM and old ARM(like ARM11) GCC .

@JonatanAntoni
Copy link
Member

JonatanAntoni commented Nov 18, 2024

Not sure if I get this. Why would one include CMSIS at all if not compiling for a (supported) Arm target? Instead of conditionally exclude content from the compiler header file probably we need to include something totally different.

cc: @christophe0606

@rsaxvc
Copy link
Author

rsaxvc commented Nov 19, 2024

For ArduPilot's simulator I'd like to be able to run the same Fourier transform on logged sensor data and get the same result. Doesn't need to run fast.

On Raspberry Pi, The least common instruction set is ARM1176JZFS, where the heavy lifting can be done with much the same DSP instructions as Cortex-M4.

For context: ARM-software/CMSIS_5#490

@JonatanAntoni
Copy link
Member

Hi @rsaxvc,

That's fair request. I still don't get the point why you'd want to include the CMSIS GCC Compiler header which provides Arm-specific defines on a non-arm target? Wouldn't it be cleaner approach to not include this header at all?

@rsaxvc
Copy link
Author

rsaxvc commented Nov 19, 2024

Sorry for the confusion, for the PC simulator, it is enough to build CMSIS-DSP in host mode and skip CMSIS6 entirely.

@JonatanAntoni
Copy link
Member

No worries. Is this PR still relevant for older ARM targets such as ARM11? Basically, CMSIS 6 doesn't claim support for anything older than Armv6-M (Cortex-M0). Still, if with simple changes we can allow your use case that'd be perfectly fine.

@rsaxvc
Copy link
Author

rsaxvc commented Nov 19, 2024

No longer relevant since I can build CMSIS-DSP in host mode - I'll close it

@rsaxvc rsaxvc closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants