Change weak target family descriptors to references #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/morph test |
Merged
|
Can you check test failures to proceed here? |
flit
force-pushed
the
refactor/weak_family_descriptors
branch
2 times, most recently
from
64c531b
to
8f6c369
Compare
|
/morph test |
flit
force-pushed
the
refactor/weak_family_descriptors
branch
from
8f6c369
to
efc73ee
Compare
|
/morph test |
3 similar comments
|
/morph test |
|
/morph test |
|
/morph test |
- This causes the g_families[] entries to be NULL if the family descriptor is not defined. So the g_families terminator was changed to all Fs and init_families() updated appropriately. - This changed saves quite a bit of .rodata.
flit
force-pushed
the
refactor/weak_family_descriptors
branch
from
7b957f4
to
3788fda
Compare
|
/morph test |
1 similar comment
|
/morph test |
|
I think this PR has gotten stale. A lot has been merged to develop, but changing to caused some issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the default weak family descriptor structs (each taking up the full family descriptor size) in
target_family.cwith weak references. The purpose is to save.rodataspace.