Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

399 replace token metadata link #402

Draft
wants to merge 28 commits into
base: develop
Choose a base branch
from
Draft

399 replace token metadata link #402

wants to merge 28 commits into from

Conversation

royscheeren
Copy link
Contributor

Scope

The token was minted with a link to our company gateway instead of general access ipfs.
This gateway is private to us, so basically a broken link but whats in the token needs to be public.

Work done

  • refactor the contract call parameters to use the generic ipfs link instead of the pinata gateway
  • use a gateway specific get function in the listener to retrieve files through our gateway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdsika jdsika Awaiting requested review from jdsika jdsika will be requested when the pull request is marked ready for review jdsika is a code owner

@jeroenbranje jeroenbranje Awaiting requested review from jeroenbranje jeroenbranje will be requested when the pull request is marked ready for review jeroenbranje is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@royscheeren