Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.3.2 #1936

Merged
merged 22 commits into from
Nov 20, 2023
Merged

Release v4.3.2 #1936

merged 22 commits into from
Nov 20, 2023

Conversation

forrestfwilliams
Copy link
Contributor

@forrestfwilliams forrestfwilliams commented Nov 20, 2023

Adds a Lambda function that fixes a bug in our EDC VPC by ensuring that the "VPC Endpoint - Consumer" endpoint has Private DNS disabled.

  • Check that the fix is working correctly in EDC UAT
  • Check that the lambda is not being created when deploying HyP3 outside of EDC
  • Run a test job in EDC UAT and confirm it works

@forrestfwilliams forrestfwilliams added the patch Bump the patch version number of this project label Nov 20, 2023
@forrestfwilliams forrestfwilliams requested a review from a team as a code owner November 20, 2023 16:19
Copy link

github-actions bot commented Nov 20, 2023

Developer checklist

  • Indicated the level of changes to this package by affixing one of these labels:

    • major -- Major changes to the API that may break current workflows
    • minor -- Minor changes to the API that do not break current workflows
    • patch -- Patches and bugfixes for the current version that do not break current workflows
    • bumpless -- Changes to documentation, CI/CD pipelines, etc. that don't affect the software's version
  • (If applicable) Updated the dependencies and indicated any downstream changes that are required

  • Added/updated documentation for these changes

  • Added/updated tests for these changes

  • If the step function code has changed, have you drained the job queue before merging?

    • For example, if the interface for a Lambda function has changed to expect different input,
      then currently running jobs (which use the old step function definition) will call the new
      function with the old input. So we must drain the job queue before deployment, so that the new
      function is only called by the new step function definition.

Reviewer checklist

  • Have all dependencies been updated?
  • Is the level of changes labeled appropriately?
  • Are all the changes described appropriately in CHANGELOG.md?
  • Has the documentation been adequately updated?
  • Are the tests adequate?

@forrestfwilliams forrestfwilliams merged commit 7a35ea4 into main Nov 20, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Bump the patch version number of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants