feat: include executed statements of exception throwing block ignored by Jacoco #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
|
We are missing a test case and some documentation. Opening for CI. Already works locally with Nopol's ( |
andre15silva
changed the title
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
andre15silva
force-pushed
the
include-block
branch
2 times, most recently
from
ed89004
to
e53df1b
Compare
Signed-off-by: André Silva <[email protected]>
andre15silva
force-pushed
the
include-block
branch
from
e53df1b
to
159178e
Compare
|
really cool.
|
|
It is ready for review. |
monperrus
changed the title
|
thanks a lot @andre15silva |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimizes #109
When the source code is available, we now include the statements of the block where an exception was thrown.
This way, the executed statements just before the exception, which might be ignored by Jacoco due to the exception limitation, are included in the coverage result.
This is not a complete fix since, sometimes, the stack-trace is lost in try/catch's of the original project.