Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding and funding updates #36

Merged
merged 9 commits into from
Aug 16, 2024
Merged

Conversation

PatCapon39
Copy link
Contributor

Commits included to:

  • Update the BioCommons logo used
  • Remove ARDC logo and funding statements
  • Update the footer text
  • Update the acknowledgment statement
  • Fix a typo on the index page (missing a)

@neoformit I noticed the old BioCommons logo had been reduced in size, so I've uploaded a small version here. Let me know if that file isn't suitable and I can upload the original full size logo.

Copy link
Collaborator

@neoformit neoformit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, if you're happy with the logo?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but it does have extra padding which results in it being displayed small. Usually logos for web have padding removed for this reason (e.g. the other footer logos). If you're happy with this, I'll merge it. Otherwise just revert to the existing file:

Old:
image

New:
image

@PatCapon39
Copy link
Contributor Author

Ah I see, no that's no good with out logo being smaller than the other ones. I'll upload a copy that doesn't have the padding. The old one is very subtly different - can you spot the difference? :D

Screenshot 2024-08-16 at 3 17 14 PM

@PatCapon39
Copy link
Contributor Author

@neoformit how's that looking?

@neoformit
Copy link
Collaborator

Ah I see, no that's no good with out logo being smaller than the other ones. I'll upload a copy that doesn't have the padding. The old one is very subtly different - can you spot the difference? :D

Yes, yes, slightly more overlapping venn diagram, very pretty 😆

@neoformit
Copy link
Collaborator

Looking much better, thanks!

image

@neoformit neoformit merged commit b5f1b2b into AU-Biocommons:master Aug 16, 2024
@PatCapon39
Copy link
Contributor Author

Ah I see, no that's no good with out logo being smaller than the other ones. I'll upload a copy that doesn't have the padding. The old one is very subtly different - can you spot the difference? :D

Yes, yes, slightly more overlapping venn diagram, very pretty 😆

Hehe, glad you spotted it! Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants