PE-D: Fix documentation bugs mentioned in PE dry run #234
Conversation
* updated interviewUtil's method to convert an interview to a string in user input format * added more test cases to existing test classes * added test classes RemarkCandidateCommandParserTest and AddPositionCommandParserTest
* added TupleTest * added test cases to various classes * fixed checkstyle errors
* changed method assertEditSuccess to call the other constructor of commandResult
* removed a test case that causes build failure in build(mac-os)
…o documentation
JeffZincatz
changed the title
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=========================================
Coverage 80.29% 80.29%
Complexity 1005 1005
=========================================
Files 119 119
Lines 2989 2989
Branches 417 417
=========================================
Hits 2400 2400
Misses 469 469
Partials 120 120 Continue to review full report at Codecov.
|
| | **Delete an interview** | `delete_i <INDEX>` e.g., `delete_i 1` | Deleted Interview: [Accountant [Bernice Yu, David Li] 18 Oct 2021 14:00 - 16:00 PENDING] | | ||
| | **Edit an interview** | `edit_i <INDEX> [position=POSITION]... [c=<INDEX>]... [date=DATE]... [time=TIME]... [duration=DURATION]... [interviewed=STATUS]...` e.g., `edit_i 2 c=1 2 date=21/10/2021 time=1400` | Edited Interview: [Data Analyst [Jenny Lim, Max Tan] 21 Oct 2021 14:00 - 16:00 PENDING] | | ||
| | **List all interviews** | `list_i` | Listed all interviews <br> 1. [Accountant [Bernice Yu, David Li] 18 Oct 2021 14:00 - 16:00 PENDING] <br> 2. [Project Manager [Bernice Yu] 20 Oct 2021 15:00 - 16:00 PENDING] | | ||
| | **Unassign candidates** | `unassign i=<INTERVIEW_INDEX> c=<CANDIDATE_INDEX>...` e.g., `unassign i=1 c=4`| Candidates removed from interview: [Project Manager [Bernice Yu] 20 Oct 2021 15:00 - 16:00 PENDING]: <br> 1. David Li | |
There was a problem hiding this comment.
I think for issue #177, we discussed that it a feedback error. Because Interview card is in YYYY-MM-DD. Only the feedback is in DD MM YYY
There was a problem hiding this comment.
So the correct format in UG should still be YYYY-MM-DD, and the feedback in the application should be changed to be the same? If so, then I will revert the changes.
There was a problem hiding this comment.
I think might be better to leave as it is (and maybe change interview card accordingly), because otherwise input is DD/MM/YYYY but display is YYYY-MM-DD. On the other hand "18 Oct 2021" is closer to user's input, but of course can change it to "18-10-2021" or something else entirely also
There was a problem hiding this comment.
I also think displaying DD MM YYYY for interview card honestly. I feel ppl are more inclined towards DD MM YYYY than YYYY-MM-DD.
So I think can merge, but create an issue to update the interview card to show DD MM YYYY.
There was a problem hiding this comment.
Sure, I'll merge it now since it looks good otherwise
Fix various documentation bugs mentioned in PE dry run.
title=in UG exampleadd_p Assistant18 Oct 2021)delete_pfind_candfind_punassigntoassign)add_cthat the position field was wrongly indicated as optionalFix #161 Fix #168 Fix #176 Fix #177 Fix #181 Fix #184 Fix #191 Fix #199 Fix #233