Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for cascading updates on interviews and candidate's interviews #268

Merged
merged 4 commits into from
Nov 7, 2021

Conversation

sueann-chua
Copy link

Changes to execute method:

  • check if positions field has been edited
  • if edited, check if positions of the interviews scheduled for the candidate matches with the updated positions applied.
  • delete candidate from all interviews with positions that they no longer apply to.
  • update candidate details to all the interviews with positions they still apply to.
  • if not edited, just update the candidate in the existing interviews scheduled for them.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #268 (db80824) into master (4ab6758) will decrease coverage by 0.10%.
The diff coverage is 30.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #268      +/-   ##
============================================
- Coverage     78.20%   78.10%   -0.11%     
- Complexity      990      991       +1     
============================================
  Files           119      119              
  Lines          3019     3028       +9     
  Branches        412      415       +3     
============================================
+ Hits           2361     2365       +4     
- Misses          535      539       +4     
- Partials        123      124       +1     
Impacted Files Coverage Δ
.../address/logic/candidate/EditCandidateCommand.java 86.95% <30.76%> (-3.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab6758...db80824. Read the comment docs.

@angnobel angnobel added this to the v1.4 milestone Nov 6, 2021
Copy link

@angnobel angnobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angnobel angnobel merged commit 53aa7a6 into AY2122S1-CS2103T-W13-1:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Upon editing position of candidate, it is not reflected in interview
4 participants