Merge pull request #529 from RichDom2185/week13/style-ppp-issues-badge

Add and style Issues badge for PPP
AY2223S1-CS2103T-W16-2 · Nov 7, 2022 · e3b2830 · e3b2830
2 parents 4820eaf + 6b5174a
commit e3b2830
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 9 deletions.
diff --git a/docs/_includes/icons/git-merge.svg b/docs/_includes/icons/git-merge.svg
diff --git a/docs/_includes/icons/issue-closed.svg b/docs/_includes/icons/issue-closed.svg
diff --git a/docs/_includes/ppp-badges.liquid b/docs/_includes/ppp-badges.liquid
@@ -11,14 +11,23 @@
 {%- for node in nodes offset:1 -%}
   {% assign data = node | split: ']]' %}{% assign tag = data | first | strip | split: '#' %}{% assign type = tag | first | strip %}{% assign number = tag | last | strip %}
   {%- if type == 'PR' -%}
-    <span class="pr-badge">
+    <span class="ppp-badge">
       {% include icons/git-merge.svg class="icon" %}
-      <a href="https://github.com/{{ site.repository }}/pull/{{ number }}">PR#{{ number }}</a>
+      <a target="_blank" href="https://github.com/{{ site.repository }}/pull/{{ number }}">PR#{{ number }}</a>
       <span class="tooltip"><strong>Pull Request</strong> #{{ number }}<br><small>View on GitHub</small></span>
     </span>
     {%- for tail in data offset:1 -%}
       {{ tail }}
     {%- endfor -%}
+  {% elsif type == 'Issue' %}
+    <span class="ppp-badge">
+      {% include icons/issue-closed.svg class="icon" %}
+      <a target="_blank" href="https://github.com/{{ site.repository }}/issues/{{ number }}">Issue#{{ number }}</a>
+      <span class="tooltip"><strong>Issue</strong> #{{ number }}<br><small>View on GitHub</small></span>
+    </span>
+    {%- for tail in data offset:1 -%}
+      {{ tail }}
+    {%- endfor -%}
   {%-else -%}
     [[{{ node }}
   {%- endif -%}

diff --git a/docs/_sass/ppp.scss b/docs/_sass/ppp.scss
@@ -1,4 +1,4 @@
-.pr-badge {
+.ppp-badge {
   $color: #8250df;
   $border-color: #d0d7de;
 

diff --git a/docs/team/yixiann.md b/docs/team/yixiann.md
@@ -75,11 +75,11 @@ Given below are my contributions to the project.
 * **Community**:
 
   * Reported bugs and suggestions for other teams in the class:
-    * Stats command do not calculate amount wasted by performing qty * price [[Issue#449]] (https://github.com/AY2223S1-CS2103T-W16-2/tp/issues/449)
-    * Stats command expiry date do not count items that expire today [Issue#448](https://github.com/AY2223S1-CS2103T-W16-2/tp/issues/448)
-    * Stats command fail on FoodRem having less than 3 items [Issue#447](https://github.com/AY2223S1-CS2103T-W16-2/tp/issues/447)
-    * Rename tag does not modify tags in items [Issue#293](https://github.com/AY2223S1-CS2103T-W16-2/tp/issues/293)
-    * Rename tag to same name is possible [Issue#273](https://github.com/AY2223S1-CS2103T-W16-2/tp/issues/273)
+    * Stats command do not calculate amount wasted by performing qty * price [[Issue#449]]
+    * Stats command expiry date do not count items that expire today [[Issue#448]]
+    * Stats command fail on FoodRem having less than 3 items [[Issue#447]]
+    * Rename tag does not modify tags in items [[Issue#293]]
+    * Rename tag to same name is possible [[Issue#273]]
 
 Other PRs: