Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/welcome message #85

Conversation

lynnlow175
Copy link

No description provided.

@lynnlow175 lynnlow175 added the enhancement New feature or request label Oct 13, 2023
@lynnlow175 lynnlow175 added this to the v1.2 milestone Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (01406d5) 74.37% compared to head (6dec987) 74.24%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
- Coverage     74.37%   74.24%   -0.13%     
- Complexity      414      416       +2     
============================================
  Files            74       74              
  Lines          1354     1359       +5     
  Branches        127      127              
============================================
+ Hits           1007     1009       +2     
- Misses          317      320       +3     
  Partials         30       30              
Files Coverage Δ
src/main/java/seedu/lovebook/MainApp.java 0.00% <ø> (ø)
...c/main/java/seedu/lovebook/logic/LogicManager.java 78.26% <100.00%> (+0.98%) ⬆️
src/main/java/seedu/lovebook/logic/Messages.java 87.50% <ø> (ø)
src/main/java/seedu/lovebook/model/Model.java 100.00% <ø> (ø)
...c/main/java/seedu/lovebook/model/ModelManager.java 100.00% <100.00%> (ø)
src/main/java/seedu/lovebook/ui/MainWindow.java 0.00% <0.00%> (ø)
src/main/java/seedu/lovebook/ui/ResultDisplay.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lynnlow175 lynnlow175 self-assigned this Oct 13, 2023
Copy link

@shishirbychapur shishirbychapur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shishirbychapur shishirbychapur merged commit 044eab8 into AY2324S1-CS2103T-F10-2:master Oct 13, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants