forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/filter #90
Merged
shishirbychapur
merged 10 commits into
AY2324S1-CS2103T-F10-2:master
from
lynnlow175:feature/filter
Oct 17, 2023
Merged
Feature/filter #90
shishirbychapur
merged 10 commits into
AY2324S1-CS2103T-F10-2:master
from
lynnlow175:feature/filter
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
============================================
+ Coverage 68.61% 69.38% +0.76%
- Complexity 417 436 +19
============================================
Files 76 79 +3
Lines 1469 1522 +53
Branches 133 141 +8
============================================
+ Hits 1008 1056 +48
- Misses 431 433 +2
- Partials 30 33 +3
☔ View full report in Codecov by Sentry. |
lynnlow175
requested review from
shishirbychapur
and removed request for
ryamgoh
October 17, 2023 09:44
shishirbychapur
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff Lynn! LGTM!
shishirbychapur
merged commit Oct 17, 2023
f9f2e58
into
AY2324S1-CS2103T-F10-2:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.