Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/filter #90

Merged

Conversation

lynnlow175
Copy link

No description provided.

@lynnlow175 lynnlow175 closed this Oct 16, 2023
@lynnlow175 lynnlow175 reopened this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5283602) 68.61% compared to head (d92f64e) 69.38%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #90      +/-   ##
============================================
+ Coverage     68.61%   69.38%   +0.76%     
- Complexity      417      436      +19     
============================================
  Files            76       79       +3     
  Lines          1469     1522      +53     
  Branches        133      141       +8     
============================================
+ Hits           1008     1056      +48     
- Misses          431      433       +2     
- Partials         30       33       +3     
Files Coverage Δ
...a/seedu/lovebook/logic/commands/FilterCommand.java 100.00% <100.00%> (ø)
...in/java/seedu/lovebook/logic/parser/CliSyntax.java 83.33% <100.00%> (ø)
...edu/lovebook/logic/parser/FilterCommandParser.java 92.30% <92.30%> (ø)
...va/seedu/lovebook/logic/parser/LoveBookParser.java 90.47% <0.00%> (-9.53%) ⬇️
...k/model/person/MetricContainsKeywordPredicate.java 90.90% <90.90%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lynnlow175 lynnlow175 requested a review from ryamgoh October 17, 2023 09:44
@lynnlow175 lynnlow175 self-assigned this Oct 17, 2023
@lynnlow175 lynnlow175 requested review from shishirbychapur and removed request for ryamgoh October 17, 2023 09:44
Copy link

@shishirbychapur shishirbychapur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff Lynn! LGTM!

@shishirbychapur shishirbychapur merged commit f9f2e58 into AY2324S1-CS2103T-F10-2:master Oct 17, 2023
5 checks passed
@lynnlow175 lynnlow175 added the enhancement New feature or request label Oct 17, 2023
@lynnlow175 lynnlow175 added this to the v1.2 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants