Skip to content

Commit

Permalink
Merge pull request #271 from ji-just-ji/master
Browse files Browse the repository at this point in the history
Fix AddParseSequenceDiagram and minor PPP fix.
  • Loading branch information
xCOLOURx authored Nov 14, 2023
2 parents 58f18b1 + 354c0c4 commit 94f3e41
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
12 changes: 6 additions & 6 deletions docs/diagrams/AddParseSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ AddCommandParser -> ParserUtil : parseModuleCode("CS2040S")
activate ParserUtil
ParserUtil --> AddCommandParser : moduleCode:ModuleCode

AddCommandParser -> ParserUtil : parseModuleCode("1")
ParserUtil --> AddCommandParser : moduleCode:ModuleCode
AddCommandParser -> ParserUtil : parseYear("1")
ParserUtil --> AddCommandParser : y:Year

AddCommandParser -> ParserUtil : parseModuleCode("1")
ParserUtil --> AddCommandParser : moduleCode:ModuleCode
AddCommandParser -> ParserUtil : parseSemester("1")
ParserUtil --> AddCommandParser : s:Semester

AddCommandParser -> ParserUtil : parseModuleCode("A")
ParserUtil --> AddCommandParser : moduleCode:ModuleCode
AddCommandParser -> ParserUtil : parseGrade("A")
ParserUtil --> AddCommandParser : g:Grade

deactivate ParserUtil

Expand Down
4 changes: 3 additions & 1 deletion docs/team/ji-just-ji.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Given below are my contributions to the project.
* Enhanced `UniquePersonList` to `UniqueModuleList` to accommodate modules instead of person.
* Enhanced `Person` object to `Module` object to accommodate for the purpose of the software.
* Upgraded Json files to accomodate for `Module` objects
* Created tests and `TypicalModules` and `ModuleBuilder` as backbone for testing commands.

* **Documentation**:
* User Guide:
Expand All @@ -30,9 +31,10 @@ Given below are my contributions to the project.
* `calculateCap` Command: elaboration and cleanup
* `calculateMCs` Command: elaboration and cleanup
* Developer Guide:
* `Storage` section of Implementation and associated diagrams.
* `Module Storage` section of Implementation and overall associated diagrams.
* `add` command section and associated diagrams.
* Added use cases UC06 and UC07
* Contributed to creation of user stories in the ideation and the development stage.

* **Community**:
* PRs reviewed (with non-trivial review comments): 4
Expand Down

0 comments on commit 94f3e41

Please sign in to comment.