Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page breaks in UG #258

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

yyyaohhh
Copy link

No description provided.

@yyyaohhh yyyaohhh added the documentation Improvements or additions to documentation label Nov 14, 2023
@yyyaohhh yyyaohhh added this to the v1.4 milestone Nov 14, 2023
@yyyaohhh yyyaohhh marked this pull request as ready for review November 14, 2023 03:15
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b7a76b) 81.67% compared to head (da1d34f) 81.67%.
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #258   +/-   ##
=========================================
  Coverage     81.67%   81.67%           
  Complexity      593      593           
=========================================
  Files            78       78           
  Lines          1746     1746           
  Branches        174      174           
=========================================
  Hits           1426     1426           
  Misses          294      294           
  Partials         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -410,7 +438,7 @@ The image below show you what ModCraft should look like after executing the `inf
<img src="images/ImagesForUG/info-after.png" alt="After executing info command" style="height:400px; margin:20px;">
</div>
<p style="text-align: center;">
The command `info CS3230` is executed. Information about the module `CS3230` is displayed.
The command info CS3230 is executed. Information about the module CS3230 is displayed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave the back ticks. Just wrap this text in md tag

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated👍

@rocketninja7
Copy link

LGTM 👍

@rocketninja7 rocketninja7 merged commit ca4b75e into AY2324S1-CS2103T-T13-0:master Nov 14, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants