Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AddParseSequenceDiagram and minor PPP fix. #271

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Fix AddParseSequenceDiagram and minor PPP fix. #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5bd1a91
Update AddExecuteSequenceDiagram.puml
ji-just-ji Nov 14, 2023
c4cc93e
Update ji-just-ji.md
ji-just-ji Nov 14, 2023
80db9ac
Merge remote-tracking branch 'upstream/master'
ji-just-ji Nov 14, 2023
042caea
Merge remote-tracking branch 'upstream/master'
ji-just-ji Nov 14, 2023
3c41a5b
Update ji-just-ji.md
ji-just-ji Nov 14, 2023
da76671
Update ji-just-ji.md
ji-just-ji Nov 14, 2023
354c0c4
Update AddParseSequenceDiagram.puml
ji-just-ji Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/diagrams/AddParseSequenceDiagram.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ AddCommandParser -> ParserUtil : parseModuleCode("CS2040S")
activate ParserUtil
ParserUtil --> AddCommandParser : moduleCode:ModuleCode

AddCommandParser -> ParserUtil : parseModuleCode("1")
ParserUtil --> AddCommandParser : moduleCode:ModuleCode
AddCommandParser -> ParserUtil : parseYear("1")
ParserUtil --> AddCommandParser : y:Year

AddCommandParser -> ParserUtil : parseModuleCode("1")
ParserUtil --> AddCommandParser : moduleCode:ModuleCode
AddCommandParser -> ParserUtil : parseSemester("1")
ParserUtil --> AddCommandParser : s:Semester

AddCommandParser -> ParserUtil : parseModuleCode("A")
ParserUtil --> AddCommandParser : moduleCode:ModuleCode
AddCommandParser -> ParserUtil : parseGrade("A")
ParserUtil --> AddCommandParser : g:Grade

deactivate ParserUtil

Expand Down
4 changes: 3 additions & 1 deletion docs/team/ji-just-ji.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Given below are my contributions to the project.
* Enhanced `UniquePersonList` to `UniqueModuleList` to accommodate modules instead of person.
* Enhanced `Person` object to `Module` object to accommodate for the purpose of the software.
* Upgraded Json files to accomodate for `Module` objects
* Created tests and `TypicalModules` and `ModuleBuilder` as backbone for testing commands.

* **Documentation**:
* User Guide:
Expand All @@ -30,9 +31,10 @@ Given below are my contributions to the project.
* `calculateCap` Command: elaboration and cleanup
* `calculateMCs` Command: elaboration and cleanup
* Developer Guide:
* `Storage` section of Implementation and associated diagrams.
* `Module Storage` section of Implementation and overall associated diagrams.
* `add` command section and associated diagrams.
* Added use cases UC06 and UC07
* Contributed to creation of user stories in the ideation and the development stage.

* **Community**:
* PRs reviewed (with non-trivial review comments): 4
Expand Down
Loading