Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge branch-add-allowance #22

Merged
merged 14 commits into from
Oct 17, 2023
Merged

Merge branch-add-allowance #22

merged 14 commits into from
Oct 17, 2023

Conversation

lckjosh
Copy link
Collaborator

@lckjosh lckjosh commented Oct 17, 2023

Fixes #5

spaceman03
spaceman03 reviewed Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@spaceman03 spaceman03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a few renaming issues

src/main/java/seedu/nuscents/data/Transaction.java Outdated Show resolved Hide resolved
src/main/java/seedu/nuscents/data/Transaction.java Outdated Show resolved Hide resolved
src/main/java/seedu/nuscents/data/TransactionList.java Outdated Show resolved Hide resolved
src/main/java/seedu/nuscents/storage/Storage.java Outdated Show resolved Hide resolved
@lckjosh lckjosh merged commit 2063ea7 into AY2324S1-CS2113-T18-4:master Oct 17, 2023
3 checks passed
@spaceman03 spaceman03 added this to the v1.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaceman03 spaceman03 spaceman03 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Add allowance
2 participants
@lckjosh @spaceman03