update lesson labels to not display when completed #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinlengch
approved these changes
Mar 25, 2024
| @@ -61,6 +61,7 @@ public StudentCard(Student student, int displayedIndex) { | |||
| remark.setText(student.getRemark().value); | |||
| student.getLessons().stream() | |||
| .sorted(Comparator.comparing(Lesson::getLessonValue)) | |||
| .forEach(lesson -> lessons.getChildren().add(new Label(lesson.getLessonValue()))); | |||
| .filter(x -> x.getLessonStatus() == 0) | |||
| .forEach(lesson -> lessons.getChildren().add(new Label(lesson.toString()))); | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
============================================
+ Coverage 75.35% 75.42% +0.06%
- Complexity 445 446 +1
============================================
Files 75 75
Lines 1473 1473
Branches 144 144
============================================
+ Hits 1110 1111 +1
+ Misses 324 323 -1
Partials 39 39 ☔ View full report in Codecov by Sentry. |
leepoeaik
merged commit 11e6056
into
AY2324S2-CS2103T-T16-4:master
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.