Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MainWindow to update student and schedule list after each command #66

Merged

Conversation

justinlengch
Copy link

No description provided.

@justinlengch justinlengch added the Bug A bug label Apr 4, 2024
@justinlengch justinlengch added this to the V1.3 milestone Apr 4, 2024
@justinlengch justinlengch self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 70.77%. Comparing base (38fa4bd) to head (139a7c1).

Files Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 9 Missing ⚠️
.../main/java/seedu/address/ui/ScheduleListPanel.java 0.00% 4 Missing ⚠️
...seedu/address/logic/commands/AddLessonCommand.java 0.00% 1 Missing ⚠️
...u/address/logic/parser/AddLessonCommandParser.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #66      +/-   ##
============================================
- Coverage     71.25%   70.77%   -0.49%     
  Complexity      455      455              
============================================
  Files            79       79              
  Lines          1604     1615      +11     
  Branches        160      161       +1     
============================================
  Hits           1143     1143              
- Misses          416      427      +11     
  Partials         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@leepoeaik leepoeaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! LGTM!

@leepoeaik leepoeaik merged commit 0498fb8 into AY2324S2-CS2103T-T16-4:master Apr 4, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants