Minor changes to Code Quality

[nur-haziq]

Summary of Changes:

Storage

• Catch ArrayIndexOutOfBoundsException. Thanks @YHWong20 for the catch.

RestockCommand and SellCommand

• Remove unused RegEx pattern, and unused imports

ItemList

• Ensured wrapping of lines around the soft limit of 110 chars
• To close minor code quality issues #274

Parser

• Included explicit //Fallthrough statement for the 2 initial switch cases that do not have a break statement

UpdateCommandParser

• Rename methods to sound more 'verb-like'

General

• Added and removed blank lines where necessary

---

For the catching of exceptions in Storage

There is an alternative solution, which is deemed as bad programming practice in most cases, which is to catch the general exception catch (Exception e).

However, in scenarios like file parsing where input can be quite variable and potentially out of the control of our application (e.g., user-modified files), it could be prudent to include such handling to ensure the application remains robust against all forms of bad input. Ultimately, all the exceptions during loading will be handled in the same way: setting isCorrupted to True, and creating a new items.txt file.

Do LMK you guys' opinion on this.

[YHWong20]

I reckon that it's better to do it this way (as opposed to catching Exception e - just for the sake of keeping our code quality relatively high). Hopefully this is the last exception that we'll need to deal with haha

[YHWong20]

Good catch!

[YHWong20]

Thanks for making the necessary changes to improve our code quality!