Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add application logic to main method of BinBash class #38

Merged
merged 10 commits into from
Mar 14, 2024
Merged

Add application logic to main method of BinBash class #38

merged 10 commits into from
Mar 14, 2024

Conversation

YHWong20
Copy link

  • Added logic to BinBash::main, and created corresponding unit tests.
  • Created a basic ByeCommand class for application functionality. @nur-haziq feel free to edit the class if necessary.
  • Added basic text UI tests.

@YHWong20 YHWong20 added this to the v1.0 milestone Mar 14, 2024
@YHWong20 YHWong20 requested a review from nur-haziq March 14, 2024 08:10
nur-haziq
nur-haziq approved these changes Mar 14, 2024
View reviewed changes
Copy link

@nur-haziq nur-haziq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/java/seedu/binbash/BinBash.java
import seedu.binbash.command.ByeCommand;

public class BinBash {
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an empty line here

@nur-haziq nur-haziq merged commit 2f9776c into AY2324S2-CS2113T-T09-2:master Mar 14, 2024
3 checks passed
@YHWong20 YHWong20 linked an issue Mar 15, 2024 that may be closed by this pull request
Update Main class to call utility classes; ensure general functionality #36
Closed
@nkotaa nkotaa mentioned this pull request Mar 20, 2024
Closed
@nkotaa nkotaa linked an issue Mar 20, 2024 that may be closed by this pull request
Implement welcome menu functionality for user text UI #22
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nur-haziq nur-haziq nur-haziq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
2 participants
@YHWong20 @nur-haziq