Add additional attributes to Item class and parameters to add methods #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/seedu/binbash/command/AddCommand.java
nkotaa
approved these changes
Mar 17, 2024
Comment on lines
+6
to
+9
| private final int itemQuantity; | ||
| private final String itemExpirationDate; | ||
| private final double itemSalePrice; | ||
| private final double itemCostPrice; |
There was a problem hiding this comment.
There might be too many variables. We could look into defining sub-classes of Item to keep this list minimal in the future. Ex. Perishable extends Item
Comment on lines
+18
to
+27
| public AddCommand(ItemList itemList, String itemName, String itemDescription, int itemQuantity, | ||
| String itemExpirationDate, double itemSalePrice, double itemCostPrice) { | ||
| super(itemList); | ||
| this.itemName = itemName; | ||
| this.itemDescription = itemDescription; | ||
| this.itemQuantity = itemQuantity; | ||
| this.itemExpirationDate = itemExpirationDate; | ||
| this.itemSalePrice = itemSalePrice; | ||
| this.itemCostPrice = itemCostPrice; | ||
|
|
There was a problem hiding this comment.
This constructor appears needlessly verbose. Perhaps we could define it with an Item parameter instead. i.e public AddCommand(Item newItem)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.