Refactor command #79
Merged
Refactor command #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our command classes, execute() returns a string for the Ui to print. This is unintuitive and conveys no information about the success or failure of the execution action. Let's have execute() return its result status instead. This would make it easier to write tests and assertions, aligning with our goals for a more robust application.
XavierLiau34
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently execute() returns a string, which is unintuitive and conveys no information about the success or failure of the outcome.
Changing it to return bool would make it easier to write tests and assertions, in line with goals #46 #47 #49 .