Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent search #162

Merged

Conversation

jan-kai1
Copy link
Collaborator

@jan-kai1 jan-kai1 commented Nov 4, 2024

Improves readability and resolve merge conflicts

shardhrv and others added 29 commits October 29, 2024 22:30
so that it preserves UUID of editedPerson
…-edit-and-delete-commands

Updated UG for Edit and Delete Commands
…d-in-eventmanager

Update editCommand and deleteCommand logic
…nt-persons

Add `view` command to view Persons in Event
@jan-kai1 jan-kai1 added this to the v1.5 milestone Nov 4, 2024
@jan-kai1 jan-kai1 self-assigned this Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ss/logic/parser/SearchModeSearchCommandParser.java 83.33% 6 Missing ⚠️
.../seedu/address/logic/parser/AddressBookParser.java 0.00% 1 Missing ⚠️
...n/java/seedu/address/model/event/EventManager.java 90.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...logic/commands/contact/commands/DeleteCommand.java 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
...s/logic/commands/contact/commands/EditCommand.java 97.77% <100.00%> (+0.05%) 14.00 <0.00> (ø)
...ogic/commands/event/commands/ViewEventCommand.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)
...u/address/logic/parser/ViewEventCommandParser.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/main/java/seedu/address/model/event/Event.java 93.39% <100.00%> (+2.14%) 48.00 <15.00> (+15.00)
...u/address/model/person/PersonInEventPredicate.java 100.00% <100.00%> (ø) 6.00 <6.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 84.21% <0.00%> (-2.28%) 18.00 <0.00> (ø)
...n/java/seedu/address/model/event/EventManager.java 94.44% <90.00%> (-5.56%) 19.00 <6.00> (+7.00) ⬇️
...ss/logic/parser/SearchModeSearchCommandParser.java 86.20% <83.33%> (-0.75%) 14.00 <5.00> (+5.00) ⬇️

... and 1 file with indirect coverage changes

@jan-kai1 jan-kai1 merged commit 185126e into AY2425S1-CS2103T-F09-2:PersistentSearch Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants