Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for searchmode #165

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Add UI for searchmode #165

merged 3 commits into from
Nov 4, 2024

Conversation

jan-kai1
Copy link
Collaborator

@jan-kai1 jan-kai1 commented Nov 4, 2024

For #164
Not sure how to do testcase for MainWindow

@jan-kai1 jan-kai1 added type.Enhancement An enhancement to an existing story priority.Medium Nice to have labels Nov 4, 2024
@jan-kai1 jan-kai1 added this to the v1.5 milestone Nov 4, 2024
@jan-kai1 jan-kai1 self-assigned this Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 16 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
...rc/main/java/seedu/address/logic/LogicManager.java 70.00% <100.00%> (+2.14%) 5.00 <2.00> (+2.00)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 100.00% <100.00%> (ø) 33.00 <5.00> (+2.00)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Copy link

@cshao02 cshao02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cshao02 cshao02 merged commit dcb7c8a into master Nov 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type.Enhancement An enhancement to an existing story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants