Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consistent format for View command #172

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

brianchoon
Copy link
Collaborator

Summary

Currently, the view command is implemented by typing the exact event name after the keyword. For example, one must type view NUS Student Life Fair 2024 to view the details of an event titled "NUS Student Life Fair 2024".

In line with the rest of our commands, we wish to refer to events by index, i.e. view 1 to view the event with ID 1.

This PR fixes this.

Issues Fixed

Fixes #171

@brianchoon brianchoon added priority.Medium Nice to have severity.Medium A flaw that causes occasional inconvenience to some users, but they can continue to use the product. alpha-bug Bugs detected for the alpha release labels Nov 5, 2024
@brianchoon brianchoon added this to the v1.5 milestone Nov 5, 2024
@brianchoon brianchoon self-assigned this Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ogic/commands/event/commands/ViewEventCommand.java 75.00% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...ic/parser/event/parser/ViewEventCommandParser.java 100.00% <100.00%> (ø) 3.00 <1.00> (ø)
...ogic/commands/event/commands/ViewEventCommand.java 78.94% <75.00%> (-21.06%) 6.00 <1.00> (-1.00)

... and 2 files with indirect coverage changes

Copy link

@cshao02 cshao02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cshao02 cshao02 merged commit 0e2b6d9 into AY2425S1-CS2103T-F09-2:master Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha-bug Bugs detected for the alpha release priority.Medium Nice to have severity.Medium A flaw that causes occasional inconvenience to some users, but they can continue to use the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Inconsistent format for View command
3 participants