Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine searchmode #179

Merged

Conversation

cshao02
Copy link

@cshao02 cshao02 commented Nov 5, 2024

Fixes #177 #169

Allows exiting of searchmode with "exit"
Changed commant to exit searchmode from "exitsearchmode" to "exitsearch"
Changed error msg from "Unknown Command" to display that the person is in command mode.

Copy link
Collaborator

@brianchoon brianchoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cshao02 cshao02 merged commit ffc6fca into AY2425S1-CS2103T-F09-2:master Nov 5, 2024
3 checks passed
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% 6 Missing ⚠️
.../seedu/address/logic/parser/AddressBookParser.java 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <100.00%> (ø) 4.00 <2.00> (+2.00)
...ogic/commands/event/commands/ViewEventCommand.java 78.94% <ø> (ø) 6.00 <0.00> (ø)
...gic/commands/searchmode/ExitSearchModeCommand.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 100.00% <ø> (ø) 33.00 <0.00> (ø)
src/main/java/seedu/address/model/event/Event.java 91.50% <ø> (ø) 45.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 87.50% <50.00%> (+0.32%) 21.00 <0.00> (+1.00)
.../java/seedu/address/model/util/SampleDataUtil.java 21.05% <0.00%> (ø) 3.00 <0.00> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Command: exitsearchmode to exitsearch
2 participants