Implement update for changing the tag labels color in the UI #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include: - updating the default color to something slightly darker - removing the category from the tag label - changing the tag label color to the category color
Codecov ReportAttention: Patch coverage is
|
KrashKart
approved these changes
Nov 5, 2024
| @@ -6,7 +6,7 @@ | |||
| * Provides categories to sort Tags into, as well as colour codes for display in the UI. | |||
| */ | |||
| public enum TagCategory { | |||
| GENERAL("#ECECEC"), // Light Grey for default color | |||
| GENERAL("#A9A9A9"), // Dark Grey for default color | |||
There was a problem hiding this comment.
Not sure if dark grey is a good colour because it could mean "invalid tag" to a user that's not familiar to our codebase, but I think it suffices for now
| tagLabel.setStyle("-fx-padding: 2; -fx-background-color: " + tag.getTagColour()); | ||
| tags.getChildren().add(tagLabel); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Nice implementation to refresh the tag status of the tags!
KrashKart
merged commit 49ca26f
into
AY2425S1-CS2103T-F14a-4:master
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
Example look:
Closes #227