Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement find by name command #54

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Re-implement find by name command #54

merged 5 commits into from
Oct 10, 2024

Conversation

KrashKart
Copy link

Fixes #52

@KrashKart
Add FindByNameCommand file
dea071e 
To be used for finding by name commands
@KrashKart
Add logic to check find type
6b6b9a0 
Use Regex to check which tag is input to find
@KrashKart
Integrate FindByNameCommand into CampusConnect
c789ccb 
Let's
* add javadocs and comments for new methods
* change FindCommandParser to return approppriate class depending on
tag
@KrashKart
Update test cases and class file
58ea80c 
Let's
* modify the regex to account for whitespace characters
* implement unit tests for AddressBookParser and FindByNameCommand
* modify unit test for FindCommandParserTest
* implement equals method (overwriting) for FindByNameCommand
@KrashKart KrashKart added type.Chore Something that needs to be done, but not a story, bug, or an epic. priority.High Must do labels Oct 10, 2024
@KrashKart KrashKart added this to the v1.2 milestone Oct 10, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../seedu/address/logic/parser/FindCommandParser.java 76.92% 1 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ Complexity Δ
...du/address/logic/commands/AbstractFindCommand.java 100.00% <100.00%> (ø) 4.00 <1.00> (?)
...eedu/address/logic/commands/FindByNameCommand.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <ø> (ø) 12.00 <0.00> (?)
.../seedu/address/logic/parser/FindCommandParser.java 80.00% <76.92%> (ø) 4.00 <4.00> (?)

@KrashKart KrashKart marked this pull request as ready for review October 10, 2024 04:34
@KrashKart KrashKart self-assigned this Oct 10, 2024
yooplo
yooplo approved these changes Oct 10, 2024
View reviewed changes
Copy link

@yooplo yooplo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok good refactoring of the find by name command. Will make the implementation of the find-by-number and find-by-email easier

@yooplo yooplo merged commit 954dd15 into AY2425S1-CS2103T-F14a-4:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yooplo yooplo yooplo approved these changes

Assignees

@KrashKart KrashKart

Labels
priority.High Must do type.Chore Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Re-implement find by name command
2 participants
@KrashKart @yooplo