Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FindByEmailCommand Class #57

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Implement FindByEmailCommand Class #57

merged 3 commits into from
Oct 10, 2024

Conversation

yooplo
Copy link

@yooplo yooplo commented Oct 10, 2024

No description provided.

@yooplo yooplo added type.Enhancement An enhancement to an existing story priority.High Must do labels Oct 10, 2024
@yooplo yooplo added this to the v1.2 milestone Oct 10, 2024
@yooplo yooplo self-assigned this Oct 10, 2024
@yooplo yooplo requested a review from KrashKart October 10, 2024 10:57
@yooplo yooplo linked an issue Oct 10, 2024 that may be closed by this pull request
Implement finding of contacts by email #46
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...edu/address/logic/commands/FindByEmailCommand.java 75.00% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...du/address/logic/commands/AbstractFindCommand.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
.../seedu/address/logic/parser/FindCommandParser.java 84.21% <100.00%> (+1.85%) 6.00 <0.00> (+1.00)
...edu/address/logic/commands/FindByEmailCommand.java 75.00% <75.00%> (ø) 3.00 <3.00> (?)

... and 1 file with indirect coverage changes

@yooplo
Copy link
Author

yooplo commented Oct 10, 2024

Closes #46

@yooplo yooplo changed the title Implement FindingByEmailCommand Class Implement FindByEmailCommand Class Oct 10, 2024
@yooplo yooplo marked this pull request as ready for review October 10, 2024 11:39
CYX22222003
CYX22222003 approved these changes Oct 10, 2024
View reviewed changes
Copy link

@CYX22222003 CYX22222003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CYX22222003 CYX22222003 merged commit 04e2b8c into AY2425S1-CS2103T-F14a-4:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CYX22222003 CYX22222003 CYX22222003 approved these changes

@KrashKart KrashKart Awaiting requested review from KrashKart

@chrisjohntan chrisjohntan Awaiting requested review from chrisjohntan

Assignees

@yooplo yooplo

Labels
priority.High Must do type.Enhancement An enhancement to an existing story
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Implement finding of contacts by email
2 participants
@yooplo @CYX22222003