Add functionality Force #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for Wedding functions.
Fix conflicts in Messages.java Fix conflicts in UntagCommand.java Fix conflicts in AddressBookParser.java Fix conflicts in AddressBook.java
Fix check style issues in Wedding classes. Fix check style issues in Wedding test classes.
Add tests for UnassignWeddingCommand.
Add tests for AssignWeddingCommand.
Add tests for DeleteWeddingCommand.
Add tests for CreateWeddingCommand.
Add ability to force the assignment of wedding. Creates a new Wedding Object if the Wedding does not already exist when using force.
Add test for force functionality.
Add javadoc to explain overloaded constructor.
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Add test to test for force functionality in AssignWeddingCommand.
dasha3412
reviewed
Oct 17, 2024
| for (Wedding wedding : weddingsToAdd) { | ||
| if (!model.hasWedding(wedding)) { | ||
| if (this.force) { | ||
| CreateWeddingCommand newWedding = new CreateWeddingCommand(wedding); |
There was a problem hiding this comment.
Maybe can make this variable 'newWeddingCommand' to make the code clearer
src/main/java/seedu/address/logic/commands/DeleteTagCommand.java
Outdated
Show resolved
Hide resolved
riccoljy
approved these changes
Oct 17, 2024
| Messages.format(targetWedding))); | ||
| } else { | ||
| throw new CommandException( | ||
| String.format(MESSAGE_DELETE_WEDDING_FAILURE_STILL_USED, Messages.format(targetWedding))); |
There was a problem hiding this comment.
CodeCov flagged this as not covered -- also couldn't find any tests that had MESSAGE_DELETE_WEDDING_FAILURE_STILL_USED as output, but maybe I overlooked!
# Conflicts: # src/main/java/seedu/address/logic/Messages.java # src/main/java/seedu/address/logic/commands/AssignWeddingCommand.java # src/main/java/seedu/address/logic/commands/CreateWeddingCommand.java # src/main/java/seedu/address/logic/commands/DeleteWeddingCommand.java # src/main/java/seedu/address/logic/commands/UnassignWeddingCommand.java # src/main/java/seedu/address/model/AddressBook.java # src/main/java/seedu/address/model/Model.java # src/main/java/seedu/address/model/ReadOnlyAddressBook.java # src/main/java/seedu/address/model/person/Person.java # src/main/java/seedu/address/model/wedding/UniqueWeddingList.java # src/main/java/seedu/address/model/wedding/Wedding.java # src/main/java/seedu/address/model/wedding/WeddingName.java # src/test/java/seedu/address/logic/parser/CreateWeddingCommandParserTest.java # src/test/java/seedu/address/logic/parser/DeleteWeddingCommandParserTest.java # src/test/java/seedu/address/model/AddressBookTest.java # src/test/java/seedu/address/testutil/TypicalPersons.java
Remove setTag from UniqueWeddingList.java.
Add Message to instruct users on Force functionality in AssignWeddingCommand
Rename newWedding to newWeddingCommand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.